Opened 13 years ago

Closed 10 years ago

#263 closed defect (fixed)

trace_get_layer2() doesn't always return layer2

Reported by: smr26 Owned by: perry
Priority: minor Milestone:
Component: libtrace-library Version: 3.0
Keywords: Cc:

Description

trace_get_layer2() will return the previous metadata header if a layer2 header isn't found. This seems non-obvious and caused me some grief, although admittedly I wasn't checking the returned linktype. Madwifi monitor mode will pass through packets with only a Radiotap header and no payload, presumably when none of the frame could be decoded. Maybe get_layer2() should return NULL in this case.

Change History (1)

comment:1 Changed 10 years ago by salcock

  • Resolution set to fixed
  • Status changed from new to closed

Think we can finally cross this one off as a result of r1714 - an example trace with Madwifi monitor mode packets would help confirm this.

Note: See TracTickets for help on using tickets.