Opened 14 years ago

Closed 14 years ago

Last modified 11 years ago

#253 closed defect (fixed)

trace_get_source_mac returns destination_mac

Reported by: anonymous Owned by: perry
Priority: major Milestone:
Component: libtrace-library Version:
Keywords: Cc:


There is an error in trace_get_source_mac. (Propably a copy-paste-error). In the case TRACE_TYPE_80211_RADIOTAP the return is wifi->mac1 but should be wifi->mac2

Change History (4)

comment:1 in reply to: ↑ description Changed 14 years ago by grauel at

Sadly there is an issue with our proposed fix. If the captured packet is an 802.11 acknowledge, it has no source_mac. In this case the return should be null. A return wifi->mac2 returns the ACKs sequence number. Currently we work around this, by returning null if the captured packetlength is 40. But there should be a better solution...

Anyways, keep up the good work! Your libtrace helps us a lot in our measurements...



Replying to anonymous:

There is an error in trace_get_source_mac. (Propably a copy-paste-error). In the case TRACE_TYPE_80211_RADIOTAP the return is wifi->mac1 but should be wifi->mac2

comment:2 Changed 14 years ago by smr26


Thanks for the bug report! It's nice to know that people are starting to use the libtrace wireless code :) Can I ask what kind of measurements you're using it for?

I've got a patch ready to commit to fix trace_get_source_mac() so that we return NULL if the frame is either of type ACK or CTS (no SA). We also now return addr2 correctly for Radiotap traces.

However, in the case of 4-address WDS frames, should we return addr2 (TA) or addr4 (SA)? My feeling is that we should just return addr2 - that way we consistently return the transmitter of the frame (which is probably what you're trying to find out). Unfortunately, it's not strictly speaking the source MAC address and so isn't quite intuitive given the name of the function.

Anybody have any thoughts?



comment:3 Changed 14 years ago by smr26

  • Resolution set to fixed
  • Status changed from new to closed

I've committed my patch in r1259. We return NULL if there is no sender address, and addr2 in all other cases. I'll close this ticket, but feel free to comment further.

comment:4 Changed 11 years ago by NicaTolcalt

Capecitabine is an antimetabolite, a drug that has a similar chemical structure to a substance normally found in the cell, but interferes with the cell's normal functions. phentermine online from united state pharmacies [ contact phentermine pharmacy - cod online order phentermine carisoprodol [ kingsport tn phentermine - 30mg phentermine no doctor approval [ fake phentermine a 159 - information on the diet pill phentermine [ discount phentermine online pills huge discounts - does phentermine cause ance [ phentermine scams - search viagra edinburgh phentermine find [ buy phentermine with mc - original phentermine no prescription [ medlineplus drug information phentermine - find search edinburgh viagra phentermine [ phentermine pim - phentermine on line with out prescription [ getting a prescription for phentermine - no presription needed phentermine [ phentermine over the counter alternative - These steps are repeated until the baby is latched on properly. tramadol if allergic to aspirin [ tramadol dysphasia - ketorolac tramadol [ zopiclone or tramadol - use of tramadol in fibromyalgia [ prescription search tramadol - tramadol fed ex overnight 180 [ tramadol withdrawal time - tramadol er dosages [ tramadol er and itching side effect - tramadol erowid experiences vault [ tramadol makes me sick - cheap soma tramadol [ tramadol for humans and dogs - tramadol for distemper [ tramadol and cymbalta interaction - is tramadol an nsaid [ does tramadol show up drug test - 4 tramadol cod [ about tramadol medecation - Consequently, the full spectrum of possible responses to selegiline may not have been observed in pre-marketing evaluation of the drug. buy adipex cheap and fast [ when does adipex start working - care health resurrection adipex diet pill [ adipex online no perscription - adipex metabolism [ adipex cod only - adipex 37.5 mg no prescription [ weight lose clinic adipex kentucky - Adults with specific phobias realize that these fears are irrational. lloyds chemist viagra [ do women take viagra - viagra no prescription required [ viagra value card program - site ebaycouk kamagra viagra sildenafil [ maca viagra - sexual stimulation required viagra [ drunk viagra - Although leprosy has been afflicting humans throughout recorded history, it was not until 1873 that Armauer Hansen, with the aid of the newly-invented microscope, identified the causative organism. order cialis online without prescription [ cialis with grapefruit - generic cialis double [ cialis pills without a prescription - online cialis sales [ german remedies cialis - cialis 20mg reviews [ comparison of viagra levitra and cialis - one a day cialis [ cialis for free - cialis viagra softabs [ cialis jokes - Acarbose was also given in food and by postprandial gavage in two separate studies in Wistar rats. soma and excedrin interactions [ cheapest soma online no prescription generic - Thalassemias are inherited blood disorders. order xanax online free consultation [ how long xanax bars drug test - ambien hydrocodone xanax [ xanax lithium - lyrica for xanax withdrawal [ is xanax a popular street drug - mixing xanax alcohol [ xanax bar pics - can xanax and lortab be mixed [ mixing alcohol and xanax - skelaxin xanax [ getting high with xanax - If indicated, there are some implanted devices that are both pacemakers and defibrillators. buy valium online no rx [ what do valiums do to you - why wont doc prescribe valium [ valium airplane - recommended valium dosage [ side effects of valium and alcohol - Teratogenic Effects.

Note: See TracTickets for help on using tickets.