Custom Query (89 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (13 - 15 of 89)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
Ticket Resolution Summary Owner Reporter
#311 fixed don't ship tracetop man page if binary is not built. salcock Matt Brown
Description

If ncurses is not present, tracetop is not built. However the manpage is always installed.

from tools/tracetop/Makefile.am man_MANS = tracetop.1 EXTRA_DIST = $(man_MANS) if HAVE_NCURSES

Moving the if to the top of the file might solve the issue.

#312 fixed tracetop no longer installed salcock Matt Brown
Description

changeset 1701 introduced a typo in configure.in which means that tracetop is no longer installed even when ncurses is present.

Attached patch should fix it.

#313 duplicate sorry for duplicate ticket by mistake. Please cancel this one. salcock Rong Zheng
Description

The length of extension header field is defined in RFC as follows, take Hop-by-Hop header for example: 8-bit unsigned integer. Length of the Hop-by-Hop Options header in 8-octet units, not including the first 8 octets.

So the len filed in libtrace_ip6_ext_t should be: len=(((libtrace_ip6_ext_t*)payload)->len + 1) * 8;

I have attached a ipv6 packet(pcap file) within two extension headers for testing.

diff -Nur ./lib/protocols_l3.c ../libtrace-3.0.11_rong/lib/protocols_l3.c
--- ./lib/protocols_l3.c	2011-07-11 21:19:47.000000000 +0800
+++ ../libtrace-3.0.11_rong/lib/protocols_l3.c	2011-07-11 21:14:47.000000000 +0800
@@ -156,12 +156,10 @@
 		switch (nxt) {
 			case 0: /* hop by hop options */
 			case TRACE_IPPROTO_ROUTING:
-			case TRACE_IPPROTO_ESP:
 			case TRACE_IPPROTO_AH: 
 			case TRACE_IPPROTO_DSTOPTS: 
 				{
-					len=((libtrace_ip6_ext_t*)payload)->len
-					+sizeof(libtrace_ip6_ext_t);
+					len=(((libtrace_ip6_ext_t*)payload)->len + 1) * 8;
 
 					if (remaining) {
 						if (*remaining < len) {
@@ -191,7 +189,11 @@
 					payload=(char*)payload+len;
 					continue;
 				}
-
+			case TRACE_IPPROTO_ESP:
+				{
+					if (prot) *prot=TRACE_IPPROTO_ESP;	//the remain part of this packet is encrypted
+					return payload;
+				}
 			default:
 				if (prot) *prot=nxt;
 				return payload;

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
Note: See TracQuery for help on using queries.