Custom Query (89 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (70 - 72 of 89)

Ticket Resolution Summary Owner Reporter
#292 fixed Investigate threading issue in libtrace IO salcock salcock
Description

If the change in r1681 is reverted, libtrace can segfault when reading traces on certain systems.

This appears to be due to a threading issue where the value of the len parameter passed into thread_read() is changed by another thread. This is in spite of the parameter being passed in by value rather than reference, as gcc appears to be optimising this parameter into a pass by reference. Disabling optimisations will prevent the problem from occurring.

The solution in r1681 is only treating the symptom, not the actual problem, so it would be good if we can find the point where the other thread touches something it shouldn't and put a mutex around it.

I've been able to replicate this on an Ubuntu 9.10 box using gcc 4.4.1 (for WAND folks, this is laptop "druid").

#310 fixed build broken by changeset 1701 salcock Matt Brown
Description

libtrace no longer compiles from source following changeset 1701 as it cannot find the libtrace library while compiling libpktdump

CXXLD libpacketdump.la

/usr/bin/ld: cannot find -ltrace collect2: ld returned 1 exit status make[3]: * [libpacketdump.la] Error 1 make[3]: Leaving directory `/home/matt/libtrace-3.0.10/libpacketdump' make[2]: * [all] Error 2 make[2]: Leaving directory `/home/matt/libtrace-3.0.10/libpacketdump' make[1]: * [all-recursive] Error 1 make[1]: Leaving directory `/home/matt/libtrace-3.0.10' make: * [all] Error 2

Please find a patch attached that should fix this.

#311 fixed don't ship tracetop man page if binary is not built. salcock Matt Brown
Description

If ncurses is not present, tracetop is not built. However the manpage is always installed.

from tools/tracetop/Makefile.am man_MANS = tracetop.1 EXTRA_DIST = $(man_MANS) if HAVE_NCURSES

Moving the if to the top of the file might solve the issue.

Note: See TracQuery for help on using queries.