Ignore:
Timestamp:
01/08/19 10:58:31 (22 months ago)
Author:
Shane Alcock <salcock@…>
Branches:
develop
Children:
0ae7ba2
Parents:
93564ff
Message:

Add more failure cases to "can_write" functions for some formats.

Specifically:

  • Avoid writing metadata packets to DPDK, ring and int
  • Make sure all formats avoid writing "content invalid" packets.
  • Add comments to remind us that erf meta <-> pcapng meta conversion might be worth adding at some point.
  • Add comment to remind us that erf meta should be writable via a DAG card (I think).
File:
1 edited

Legend:

Unmodified
Added
Removed
  • lib/format_linux_ring.c

    r32de4c7 rfce4572  
    7575        libtrace_linktype_t ltype = trace_get_link_type(packet);
    7676
     77        if (ltype == TRACE_TYPE_CONTENT_INVALID) {
     78                return false;
     79        }
    7780        if (ltype == TRACE_TYPE_NONDATA) {
     81                return false;
     82        }
     83        if (ltype == TRACE_TYPE_PCAPNG_META) {
     84                return false;
     85        }
     86        if (ltype == TRACE_TYPE_ERF_META) {
    7887                return false;
    7988        }
Note: See TracChangeset for help on using the changeset viewer.