Changeset f7bcbfb for libpacketdump

Timestamp:

02/21/14 10:38:06 (7 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

a31777e

Parents:

86bec15

Message:

Fixed warnings that cropped up when building with clang

• Added proper "unknown" or "error" values to some libtrace enums. This removes the need for the hideous ==~0U checks that we used to do to check for errors and should be a bit more robust.
• Fixed potential strncat bugs in one of the libpacketdump decoders.
• Changed some null-ops in ior-peek as our current method was triggering warnings.

File:

• libpacketdump/eth_2054.c (modified) (1 diff)

libpacketdump/eth_2054.c

@@ -65 +65 @@
                         break;
                 default:
-                        strncat(buffer," (",sizeof(buffer));
+                        snprintf(buffer, sizeof(buffer), "%s", " (");
                         for (i=0;i<arp->ar_pln;i++) {
                                 snprintf(buffer,sizeof(buffer),"%s %02x",
                                                 buffer,(unsigned char)pro[i]);
                         }
-                        strncat(buffer,")",sizeof(buffer));
+                        strncat(buffer,")",sizeof(buffer) - strlen(buffer) - 1);
                         break;
         }