Changeset e732393 for lib


Ignore:
Timestamp:
05/18/18 11:39:59 (3 years ago)
Author:
Shane Alcock <salcock@…>
Branches:
cachetimestamps, develop, etsilive, master, rc-4.0.4, ringdecrementfix, ringperformance
Children:
cc9c9de
Parents:
691b182
git-author:
Shane Alcock <salcock@…> (04/10/18 15:14:22)
git-committer:
Shane Alcock <salcock@…> (05/18/18 11:39:59)
Message:

Improve error explanation when in-libtrace filtering fails.

The typical failure case is because the packet linktype does not
correspond to a pcap DLT, which BPF needs to apply filters
properly.

Since the packets being filtered may not actually be pcap, an
error message that complains about pcap is rather confusing.
Better to be more detailed about what went wrong.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • lib/trace.c

    rb663d33 re732393  
    15461546                                trace_set_err(packet->trace,
    15471547                                                TRACE_ERR_NO_CONVERSION,
    1548                                                 "pcap does not support this format");
     1548                                                "pcap does not support this linktype so cannot apply BPF filters");
    15491549                                if (free_packet_needed) {
    15501550                                        trace_destroy_packet(packet_copy);
Note: See TracChangeset for help on using the changeset viewer.