Changeset dea08f1

Timestamp:

02/28/17 13:47:49 (4 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, master, ndag_format, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

db84bb2

Parents:

cac1d92

Message:

Fix wandio race conditions

libwandio is not thread-safe, so file-based formats need to
be careful about when try to operate on the file.

This should fix most of the issues with crashes, segfaults, etc.
when reading from files (including most of our parallel file test
cases!)

File:

• lib/trace_parallel.c (modified) (1 diff)

lib/trace_parallel.c

@@ -677 +677 @@
                         if (!trace->pread) {
                                 assert(packets[0]);
+                                ASSERT_RET(pthread_mutex_lock(&trace->libtrace_lock), == 0);
                                 nb_packets = trace_read_packet(trace, packets[0]);
+                                ASSERT_RET(pthread_mutex_unlock(&trace->libtrace_lock), == 0);
                                 packets[0]->error = nb_packets;
                                 if (nb_packets > 0)