Changeset d99c759

Timestamp:

03/17/10 16:50:34 (12 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

026eb88

Parents:

666b5cf

Message:

• Increased maximum TCP segment size supported by tracereport *again*
• Fixed tracereport to not segfault when it gets a segment larger than it supports - now it prints an error message and carries on

File:

• tools/tracereport/tcpsegment_report.c (modified) (2 diffs)

tools/tracereport/tcpsegment_report.c

@@ -7 +7 @@
 #include "report.h"
 
-static stat_t tcpseg_stat[3][9000] = {{{0,0}}} ;
+#define MAX_SEG_SIZE 10000
+
+static stat_t tcpseg_stat[3][MAX_SEG_SIZE + 1] = {{{0,0}}} ;
 static bool suppress[3] = {true,true,true};
 
@@ -26 +28 @@
         ip_len = ntohs(ip->ip_len);
         ss = ip_len - (ip->ip_hl * 4);
+
+        if (ss > MAX_SEG_SIZE) {
+                fprintf(stderr, "Maximum segment size %u exceeded - size was %u\n",
+                                MAX_SEG_SIZE, ss);
+                return;
+        }
+
 
         tcpseg_stat[dir][ss].count++;