Changeset d242ea8 for tools/tracestats/tracestats.c

Timestamp:

02/07/07 16:46:43 (14 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

43ab7b3

Parents:

205809b

Message:

Some of tracesummary's bpf filters were incorrect - however the new correct filters don't work so well with the output format so that will need fixing at some point
Improved error reporting for bpf filters
tracestats will now ignore a filter that fails and print a single warning. It also no longer increments the counter for filters that fail.

File:

• tools/tracestats/tracestats.c (modified) (3 diffs)

tools/tracestats/tracestats.c

@@ -100 +100 @@
 
                 for(i=0;i<filter_count;++i) {
-                        if(trace_apply_filter(filters[i].filter,packet)) {
+                        if (filters[i].filter == NULL)
+                                continue;
+                        if(trace_apply_filter(filters[i].filter,packet) > 0) {
                                 ++filters[i].count;
                                 filters[i].bytes+=trace_get_wire_length(packet);
+                        }
+                        if (trace_is_err(trace)) {
+                                trace_perror(trace, "trace_apply_filter");
+                                fprintf(stderr, "Removing filter from filterlist\n");
+                                filters[i].filter = NULL;
                         }
                 }
@@ -110 +117 @@
         }
 
+        printf("%-30s\t%12s\t%12s\t%7s\n","filter","count","bytes","%");
         for(i=0;i<filter_count;++i) {
                 printf("%30s:\t%12"PRIu64"\t%12"PRIu64"\t%7.03f\n",filters[i].expr,filters[i].count,filters[i].bytes,filters[i].count*100.0/count);
@@ -165 +173 @@
         }
 
-        printf("%-30s\t%12s\t%12s\t%7s\n","filter","count","bytes","%");
         for(i=optind;i<argc;++i) {
                 run_trace(argv[i]);