Changeset ceba2b2

Timestamp:

12/26/16 14:00:03 (4 years ago)

Author:

GitHub <noreply@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, master, ndag_format, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

2d4e055

Parents:

47c4490

git-author:

EaseTheWorld <easetheworld@…> (12/26/16 14:00:03)

git-committer:

GitHub <noreply@…> (12/26/16 14:00:03)

Message:

Avoid using double in store_first_packet()

'integer-to-double' conversion is not architecture compatible.
(When I compiled libtrace in xeon and run in atom, 'Illegal instruction' error occured.)
Maybe I could use arch compiler option, but still 'double' should be avoided.

File:

• lib/trace_parallel.c (modified) (1 diff)

lib/trace_parallel.c

@@ -1012 +1012 @@
                         /* Check if we are newer than the previous 'first' packet */
                         size_t first = libtrace->first_packets.first;
-                        if (trace_get_seconds(dup) <
-                                trace_get_seconds(libtrace->first_packets.packets[first].packet))
+                        struct timeval cur_ts = trace_get_timeval(dup);
+                        struct timeval first_ts = trace_get_timeval(libtrace->first_packets.packets[first].packet);
+                        if (timercmp(&cur_ts, &first_ts, <))
                                 libtrace->first_packets.first = t->perpkt_num;
                 }