Changeset c22a4bb

Timestamp:

04/30/18 13:54:55 (2 years ago)

Author:

Richard Sanger <rsanger@…>

Branches:

cachetimestamps, develop, etsilive, master, rc-4.0.4, ringdecrementfix, ringperformance

Children:

6d17620

Parents:

dc27de3

Message:

Return error if change perpkt threads on paused trace

We do not have code to change the number of perpkt threads, once
a trace had been started. However, you could set the perpkt threads
without an error being returned on a paused trace - but this never
got applied.

This clarifies docs and returns an error to match with the behaviour.

Location:

lib

Files:

• libtrace_parallel.h (modified) (1 diff)
• trace_parallel.c (modified) (1 diff)

lib/libtrace_parallel.h

@@ -731 +731 @@
 /** Set the maximum number of perpkt threads to use in a trace.
  *
+ * Only valid on a new trace, that has not be started. Once started
+ * the number of threads cannot be changed without destroying the trace.
+ *
  * @param[in] trace The parallel input trace
  * @param[in] nb The number of threads to use. If set to 0, libtrace will

lib/trace_parallel.c

@@ -2403 +2403 @@
 
 DLLEXPORT int trace_set_perpkt_threads(libtrace_t *trace, int nb) {
-        if (!trace_is_configurable(trace)) return -1;
+        // Only supported on new traces not paused traces
+        if (trace->state != STATE_NEW) return -1;
 
         /* TODO consider allowing an offset from the total number of cores i.e.