Changeset bb0a1f4 for lib

Timestamp:

04/06/16 17:01:41 (5 years ago)

Author:

Richard Sanger <rsanger@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, master, ndag_format, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

74516fe, f030e50

Parents:

38c00dd

Message:

Use the default DPDK device driver rx/tx thresholds

DPDK 1.8 introduced default thresholds per device driver, these
perform better then what we were using.

Quickly tested rx and tx on DPDK 1.7.1, 1.8 & 2.0 with the
1G 82580 NIC and 10G 82599. All appear to functional, and
should be faster with the i40e.

Fixes issue #26

File:

• lib/format_dpdk.c (modified) (3 diffs)

lib/format_dpdk.c

@@ -135 +135 @@
 #else
 #       define DPDK_USE_LOG_LEVEL 0
+#endif
+
+/* 1.8.0-rc2
+ * rx/tx_conf thresholds can be set to NULL in rte_eth_rx/tx_queue_setup
+ * this uses the default values, which are better tuned per device
+ * See issue #26
+ */
+#if RTE_VERSION >= RTE_VERSION_NUM(1, 8, 0, 2)
+#       define DPDK_USE_NULL_QUEUE_CONFIG 1
+#else
+#       define DPDK_USE_NULL_QUEUE_CONFIG 0
 #endif
 
@@ -898 +909 @@
      */
     ret = rte_eth_tx_queue_setup(format_data->port, format_data->queue_id,
-                        format_data->nb_tx_buf, rte_socket_id(), &tx_conf);
+                        format_data->nb_tx_buf, rte_socket_id(),
+                        DPDK_USE_NULL_QUEUE_CONFIG ? NULL : &tx_conf);
     if (ret < 0) {
         snprintf(err, errlen, "Intel DPDK - Cannot configure TX queue on port"
@@ -908 +920 @@
     ret = rte_eth_rx_queue_setup(format_data->port, format_data->queue_id,
                             format_data->nb_rx_buf, rte_socket_id(),
-                            &rx_conf, format_data->pktmbuf_pool);
+                            DPDK_USE_NULL_QUEUE_CONFIG ? NULL : &rx_conf,
+                            format_data->pktmbuf_pool);
     if (ret < 0) {
         snprintf(err, errlen, "Intel DPDK - Cannot configure RX queue on port"