Changeset abc8e94

Timestamp:

04/08/06 16:13:30 (15 years ago)

Author:

Perry Lorier <perry@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

8afe034

Parents:

c7658ea

Message:

Fix a security flaw
Tidy up some code

File:

• lib/trace.c (modified) (2 diffs)

lib/trace.c

@@ -1009 +1009 @@
 #else
         assert(!"This should never be called when BPF not enabled");
+        trace_set_err(packet->trace,TRACE_ERR_OPTION_UNAVAIL,
+                                "Feature unavailable");
+        return -1;
 #endif
 }
@@ -1382 +1385 @@
 {
         char *buf2 = buf;
-        static char staticbuf[17]={0,};
+        static char staticbuf[18]={0,};
         if (!buf2)
                 buf2=staticbuf;
-        sprintf(buf2,"%02x:%02x:%02x:%02x:%02x:%02x",
+        snprintf(buf2,18,"%02x:%02x:%02x:%02x:%02x:%02x",
                         addr[0],addr[1],addr[2],
                         addr[3],addr[4],addr[5]);