Changeset aa22b5b for lib/protocols_transport.c

Timestamp:

10/31/08 13:51:59 (13 years ago)

Author:

Perry Lorier <perry@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

13fd6e1

Parents:

5d4e520

Message:

If we have a complete header, but truncated at the end of it, we shouldn't return NULL from
get_payload_from_* functions so we can distinguish it from a truncated header.

File:

• lib/protocols_transport.c (modified) (4 diffs)

lib/protocols_transport.c

@@ -37 +37 @@
                         
                 default:
+                        printf("unknown ethertype=%04x\n",ethertype);
                         *proto=0;
                         return NULL;
@@ -118 +119 @@
 {
         if (remaining) {
-                if (*remaining <= sizeof(libtrace_udp_t)) {
+                if (*remaining < sizeof(libtrace_udp_t)) {
                         *remaining = 0;
                         return NULL;
@@ -131 +132 @@
         unsigned int dlen = tcp->doff*4;
         if (remaining) {
-                if (*remaining <= dlen) {
+                if (*remaining < dlen) {
                         *remaining = 0;
                         return NULL;
@@ -143 +144 @@
 {
         if (remaining) {
-                if (*remaining <= sizeof(libtrace_icmp_t)) {
+                if (*remaining < sizeof(libtrace_icmp_t)) {
                         *remaining = 0;
                         return NULL;