Changeset 8bc167a

Timestamp:

01/22/10 11:20:12 (11 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

7da2676

Parents:

1481ba7

Message:

• Upped the RT buffer size to be able to deal with full-payload jumbograms (at the cost of a larger memory imprint per-packet)

File:

• lib/format_rt.c (modified) (1 diff)

lib/format_rt.c

@@ -286 +286 @@
 }
 
-#define RT_BUF_SIZE 4000U
+
+/* I've upped this to 10K to deal with jumbo-grams that have not been snapped
+ * in any way. This means we have a much larger memory overhead per packet
+ * (which won't be used in the vast majority of cases), so we may want to think
+ * about doing something smarter, e.g. allocate a smaller block of memory and
+ * only increase it as required.
+ *
+ * XXX Capturing off int: can still lead to packets that are larger than 10K,
+ * in instances where the fragmentation is done magically by the NIC. This
+ * is pretty nasty, but also very rare.
+ */
+#define RT_BUF_SIZE 10000U
 
 static int rt_read(libtrace_t *libtrace, void **buffer, size_t len, int block)