Changeset 857729e

Timestamp:

11/09/18 10:50:59 (4 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

develop, master

Children:

4819d75

Parents:

bc86030

Message:

format_ndag: fixed uninitialised "ssock->srcaddr" bug

This bug was causing a segfault on start-up when using 'ndag:'.

File:

• lib/format_ndag.c (modified) (2 diffs)

lib/format_ndag.c

@@ -752 +752 @@
         }
 
+        ssock->sock = join_multicast_group(src.groupaddr, src.localiface,
+                        NULL, src.port, &(ssock->srcaddr));
+
+        if (ssock->sock < 0) {
+                return -1;
+        }
+
+        if (ssock->sock > rt->maxfd) {
+                rt->maxfd = ssock->sock;
+        }
+
 #if HAVE_DECL_RECVMMSG
         for (i = 0; i < RECV_BATCH_SIZE; i++) {
@@ -772 +783 @@
         ssock->recordcount = 0;
         rt->sourcecount += 1;
-
-        ssock->sock = join_multicast_group(src.groupaddr, src.localiface,
-                        NULL, src.port, &(ssock->srcaddr));
-
-        if (ssock->sock < 0) {
-                return -1;
-        }
-
-        if (ssock->sock > rt->maxfd) {
-                rt->maxfd = ssock->sock;
-        }
 
         fprintf(stderr, "Added new stream %s:%u to thread %d\n",