Changeset 708f9ae for lib/format_pcap.c

Timestamp:

08/01/07 16:58:15 (15 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

82b26ab

Parents:

646aca1

Message:

• Updated a number of formats to not set the libtrace error for config options they didn't understand. trace_config will attempt to set the option upon their return and should be trusted to set the error appropriately if it also fails.
• Updated the synopt report to report percentages of option combos in SYNs and SYNACKs separately

File:

• lib/format_pcap.c (modified) (2 diffs)

lib/format_pcap.c

@@ -132 +132 @@
                 case TRACE_OPTION_META_FREQ:
                         /* No meta data for this format */
+                case TRACE_OPTION_EVENT_REALTIME:
                 default:
-                        trace_set_err(libtrace,TRACE_ERR_UNKNOWN_OPTION,
-                                        "Unknown option %i", option);
                         return -1;
         }
@@ -191 +190 @@
                 case TRACE_OPTION_META_FREQ:
                         /* No meta-data for this format */
+                case TRACE_OPTION_EVENT_REALTIME:
+                        /* live interface is always real-time! */
                 default:
-                        trace_set_err(libtrace,TRACE_ERR_UNKNOWN_OPTION,
-                                        "Unknown option %i", option);
+                        /* Don't set an error here - trace_config will try
+                         * to handle the option when we return. If it can't
+                         * deal with it, then it will do the necessary
+                         * error-setting. */
                         return -1;
         }