Changeset 6f43f5c

Timestamp:

11/14/18 10:45:49 (4 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

develop

Children:

89609d0

Parents:

0bb8d49

git-author:

Shane Alcock <salcock@…> (10/24/18 14:42:47)

git-committer:

Shane Alcock <salcock@…> (11/14/18 10:45:49)

Message:

Force burst size to be 1 for ring: parallel inputs

We only read one packet at a time anyway, so by fixing the
burst size to 1 we can avoid a whole bunch of pointless
looping over items in an array of packets which are never
used (i.e. checking if they are valid packet structures
etc.).

File:

• lib/format_linux_ring.c (modified) (2 diffs)

lib/format_linux_ring.c

@@ -320 +320 @@
 #ifdef HAVE_PACKET_FANOUT
 static int linuxring_pstart_input(libtrace_t *libtrace) {
+        /* Only because our pread is hard-coded to only do one
+         * packet at a time anyway */
+        libtrace->config.burst_size = 1;
         return linuxcommon_pstart_input(libtrace, linuxring_start_input_stream);
 }
@@ -609 +612 @@
                                    UNUSED size_t nb_packets) {
         /* For now just read one packet */
+        /* If we change this to actually read nb_packets, make sure
+         * we remove the burst_size override in linuxring_pstart_input()
+         */
         packets[0]->error = linuxring_read_stream(libtrace, packets[0],
                                                   t->format_data, &t->messages);