Ignore:
Timestamp:
02/18/15 17:41:48 (7 years ago)
Author:
Richard Sanger <rsangerarj@…>
Branches:
4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes
Children:
e4f27d1
Parents:
8bcc925
Message:

Deprecate trace_get_filtered/accepted/recevied/dropped() in favour of a single function

Adds the single trace_get_statistics function. This allows the structure to be filled
at a point in time, rather than making multiple calls to the library during which state
might have changed.

This has been designed such that the structure can be added to in the future without
breaking old code.

The old internal get_captured_packets was removed from the formats as it was never used.
Eventually we should completely remove get_filtered and received from the formats and replace
them with get_statistics.

In additon some extra fields have added, such as error and captured and the pre-existing
fields are better defined.

The linux formats have been updated to use this new API, which combined with reading
/proc/net/dev returns a full set of statistics.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • lib/format_linux_ring.c

    r3e89670 r5ab626a  
    745745        linuxring_set_capture_length,   /* set_capture_length */
    746746        NULL,                           /* get_received_packets */
    747         linuxcommon_get_filtered_packets,/* get_filtered_packets */
    748         linuxcommon_get_dropped_packets,/* get_dropped_packets */
    749         linuxcommon_get_captured_packets,/* get_captured_packets */
     747        NULL,                           /* get_filtered_packets */
     748        NULL,                           /* get_dropped_packets */
     749        linuxcommon_get_statistics,     /* get_statistics */
    750750        linuxcommon_get_fd,             /* get_fd */
    751751        linuxring_event,                /* trace_event */
     
    757757        linuxcommon_pause_input,        /* ppause */
    758758        linuxcommon_fin_input,          /* p_fin */
    759         linuxcommon_pconfig_input,      /* pconfig input */
    760         linuxcommon_pregister_thread,
    761         NULL
     759        linuxcommon_pconfig_input,      /* pconfig input */
     760        linuxcommon_pregister_thread,   /* register thread */
     761        NULL,                           /* unregister thread */
     762        NULL                            /* get thread stats */
    762763};
    763764#else
     
    805806        NULL,                           /* get_filtered_packets */
    806807        NULL,                           /* get_dropped_packets */
    807         NULL,                           /* get_captured_packets */
     808        linuxcommon_get_statistics,     /* get_statistics */
    808809        NULL,                           /* get_fd */
    809810        NULL,                           /* trace_event */
Note: See TracChangeset for help on using the changeset viewer.