Changeset 5732e9b

Timestamp:

11/01/17 13:26:08 (3 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

cachetimestamps, develop, dpdk-ndag, etsilive, master, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance

Children:

9d00fb13

Parents:

9cdbedb

Message:

Fix bad IPv6 fragment offset calculation.

This has been horribly broken the whole time, but we generally got
lucky and fell through to the default "no fragmentation" case.
Since nobody uses IPv6 fragmentation, this seemed to be giving the
correct result.

Of course, on the odd occasion we'd accidentally treat a packet as
a fragment incorrectly and therefore trace_get_source_port() etc
would fail -- this was a bit more problematic :)

File:

• lib/protocols_l3.c (modified) (1 diff)

lib/protocols_l3.c

@@ -752 +752 @@
         if (ethertype == TRACE_ETHERTYPE_IPV6) {
                 libtrace_ip6_t *ip6 = (libtrace_ip6_t *)l3;
-                void *payload = ip6++;
+                void *payload = ip6 + 1;
                 uint8_t nxt = ip6->nxt;
                 uint16_t len;