Changeset 528a27c

Timestamp:

06/26/18 18:04:03 (2 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

cachetimestamps, develop, master, rc-4.0.4, ringdecrementfix, ringperformance

Children:

32ee9b2

Parents:

f9df20e

Message:

Add mutex around pagesize in format_linux_ring.c

This is just to keep helgrind happy -- probably not strictly
necessary but unlikely to impact performance in any meaningful
way.

File:

• lib/format_linux_ring.c (modified) (3 diffs)

lib/format_linux_ring.c

@@ -70 +70 @@
 /* Cached page size, the page size shouldn't be changing */
 static int pagesize = 0;
+
+static pthread_mutex_t pagesize_mutex;
 
 /*
@@ -88 +90 @@
         struct ifreq ifr;
         unsigned max_frame = LIBTRACE_PACKET_BUFSIZE;
-        pagesize = getpagesize();
+        pthread_mutex_lock(&pagesize_mutex);
+        if (pagesize == 0) {
+                pagesize = getpagesize();
+        }
+        pthread_mutex_unlock(&pagesize_mutex);
 
         strcpy(ifr.ifr_name, uri);
@@ -835 +841 @@
 void linuxring_constructor(void)
 {
+        pthread_mutex_init(&pagesize_mutex, NULL);
         register_format(&linuxring);
 }