Changeset 4b6495c3 for lib/format_linux.c

Timestamp:

09/28/09 10:58:05 (11 years ago)

Author:

Perry Lorier <perry@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

dfda78f

Parents:

66cf27f

Message:

Be more clear about why we failed to create a socket, so people understand you
need to run as root.

File:

• lib/format_linux.c (modified) (3 diffs)

lib/format_linux.c

@@ -130 +130 @@
                                 socket(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL));
         if (FORMAT(libtrace->format_data)->fd==-1) {
-                trace_set_err(libtrace, TRACE_ERR_INIT_FAILED, "Could not create raw socket");
+                trace_set_err(libtrace, errno, "Could not create raw socket");
                 free(libtrace->format_data);
                 return -1;
@@ -152 +152 @@
                                 (socklen_t)sizeof(addr))==-1) {
                 free(libtrace->format_data);
-                trace_set_err(libtrace, TRACE_ERR_INIT_FAILED, "Failed to bind to interface %s", libtrace->uridata);
+                trace_set_err(libtrace, errno, "Failed to bind to interface %s", libtrace->uridata);
                 return -1;
         }
@@ -258 +258 @@
         if (FORMAT(libtrace->format_data)->filter != NULL)
                 free(FORMAT(libtrace->format_data)->filter);
-        free(libtrace->format_data);
+        if (libtrace->format_data)
+                free(libtrace->format_data);
         
         return 0;