Changeset 4854e88

Timestamp:

01/11/19 14:05:42 (2 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

develop

Children:

9a792a9

Parents:

6d2a120

Message:

Don't return uninitialised timevals / timespecs on error

Bug was introduced into both pcapfile and pcapng formats.

Location:

lib

Files:

• format_pcapfile.c (modified) (2 diffs)
• format_pcapng.c (modified) (1 diff)

lib/format_pcapfile.c

@@ -589 +589 @@
         struct timeval ts;
 
+        memset(&ts, 0, sizeof(struct timeval));
+
         if (!packet) {
                 fprintf(stderr, "NULL packet passed to pcapfile_get_timeval()\n");
@@ -618 +620 @@
         struct timespec ts;
 
+        memset(&ts, 0, sizeof(struct timespec));
         if (!packet) {
                 fprintf(stderr, "NULL packet passed to pcapfile_get_timespec()");

lib/format_pcapng.c

@@ -1829 +1829 @@
         uint32_t interfaceid = 0;
         pcapng_interface_t *interface;
+
+        memset(&ts, 0, sizeof(struct timespec));
 
         if (!packet) {