Changeset 411666a for lib/protocols_transport.c

Timestamp:

12/19/07 11:17:58 (13 years ago)

Author:

Shane Alcock <salcock@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

a78665c

Parents:

287b2b4

Message:

• Fixed get_payload_from_X functions not returning NULL in cases where they have a full X header but no subsequent payload (i.e. remaining would be exactly 0 upon return)
• trace_get_layer3 should not be a SIMPLE_FUNCTION anymore
• trace_get_ip now checks that at least a full IPv4 header is present
• Calls to payload_from_ethernet functions inside trace_get_layer3 will now update remaining correctly

File:

• lib/protocols_transport.c (modified) (4 diffs)

lib/protocols_transport.c

@@ -19 +19 @@
         transport = trace_get_layer3(packet,&ethertype,remaining);
 
-        if (!transport)
+        if (!transport || *remaining == 0)
                 return NULL;
 
@@ -118 +118 @@
 {
         if (remaining) {
-                if (*remaining < sizeof(libtrace_udp_t))
+                if (*remaining <= sizeof(libtrace_udp_t))
                         return NULL;
                 *remaining-=sizeof(libtrace_udp_t);
@@ -129 +129 @@
         unsigned int dlen = tcp->doff*4;
         if (remaining) {
-                if (*remaining < dlen)
+                if (*remaining <= dlen)
                         return NULL;
                 *remaining-=dlen;
@@ -139 +139 @@
 {
         if (remaining) {
-                if (*remaining < sizeof(libtrace_icmp_t))
+                if (*remaining <= sizeof(libtrace_icmp_t))
                         return NULL;
                 *remaining-=sizeof(libtrace_icmp_t);