Changeset 22e626a

Timestamp:

05/04/10 16:08:40 (11 years ago)

Author:

Perry Lorier <perry@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

10cf089

Parents:

d6cd078

Message:

Add better discussion on LINKTYPEs vs DLTs

File:

• lib/libtrace.h.in (modified) (2 diffs)

lib/libtrace.h.in

@@ -228 +228 @@
  */
 typedef enum {
-        TRACE_DLT_NULL = 0,
+        /** pcap documents this as having the Address Family value in host byte order as the 
+          * framing.  Ugly? Yes.
+          */
+        TRACE_DLT_NULL = 0, 
         TRACE_DLT_EN10MB = 1,
         TRACE_DLT_PPP = 9,
         TRACE_DLT_ATM_RFC1483 = 11,
         
-        /* Sigh. This is handled in files with LINKTYPE's */
+        /** Ok, so OpenBSD has a different value for DLT_RAW as the rest of the planet, so detect
+          * this.  When reading to/from files we should be using TRACE_DLT_LINKTYPE_RAW instead.
+          * When talking about DLT's inside libtrace tho, we should be using /these/ DLT's.
+          */
 #ifdef __OpenBSD__
         TRACE_DLT_RAW = 14,     
@@ -240 +246 @@
 #endif
         TRACE_DLT_PPP_SERIAL = 50,
-        TRACE_DLT_LINKTYPE_RAW = 101,
+        TRACE_DLT_LINKTYPE_RAW = 101, /**< See TRACE_DLT_RAW for explainations of pain. */
         TRACE_DLT_C_HDLC = 104,
         TRACE_DLT_IEEE802_11 = 105,