Changeset 1b95fd0

Timestamp:

05/23/06 14:56:06 (15 years ago)

Author:

Perry Lorier <perry@…>

Branches:

4.0.1-hotfixes, cachetimestamps, develop, dpdk-ndag, etsilive, getfragoff, help, libtrace4, master, ndag_format, pfring, rc-4.0.1, rc-4.0.2, rc-4.0.3, rc-4.0.4, ringdecrementfix, ringperformance, ringtimestampfixes

Children:

63f4967

Parents:

f6c2d8d

Message:

Don't wander off the end of the packet when the packet was prematurely snapped
when looking at packets that were snapped before the end of the IPv6 header
when looking for the source/dest port.

File:

• lib/protocols.c (modified) (2 diffs)

lib/protocols.c

@@ -337 +337 @@
 {
         void *transport;
-        uint8_t dummy;
+        uint8_t dummy_proto;
         uint16_t ethertype;
         void *link;
-
-        if (!proto) proto=&dummy;
-
-        if (remaining)
-                *remaining = trace_get_capture_length(packet);
+        uint32_t dummy_remaining;
+
+        if (!proto) proto=&dummy_proto;
+
+        if (!remaining) remaining=&dummy_remaining;
+
+        *remaining = trace_get_capture_length(packet);
 
         link=trace_get_link(packet);
@@ -500 +502 @@
 DLLEXPORT uint16_t trace_get_source_port(const libtrace_packet_t *packet)
 {
+        uint32_t remaining;
         struct ports_t *port = 
                 (struct ports_t*)trace_get_transport((libtrace_packet_t*)packet,
-                        NULL, NULL);
+                        NULL, &remaining);
+
+        /* snapped too early */
+        if (remaining<2)
+                return 0;
 
         if (port)